[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310314#comment-14310314
 ] 

Hongchao Deng commented on ZOOKEEPER-2094:
------------------------------------------

Cool. Have done a merge and reviewed completely. Great work [~iandi].

I only changed some comments in Netty Client. No code change. 

I messed up my git so open another RB:
https://reviews.apache.org/r/30753/diff/#

[~iandi], Please do another review. Thanks!
[~fpj], Can you take a review at the RB? I think Ian and I are reaching the 
final consensus.

> SSL feature on Netty
> --------------------
>
>                 Key: ZOOKEEPER-2094
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2094
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: server
>    Affects Versions: 3.4.6, 3.5.0
>            Reporter: Ian Dimayuga
>            Assignee: Ian Dimayuga
>             Fix For: 3.5.1, 3.6.0
>
>         Attachments: ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
> ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, ZOOKEEPER-2094.patch, 
> ZOOKEEPER-2094.patch, test.cert, testKeyStore.jks, testTrustStore.jks, 
> testUntrustedKeyStore.jks
>
>
> Add SSL handler to Netty pipeline, and a default X509AuthenticationProvider 
> to perform authentication.
> Review board: https://reviews.apache.org/r/30576/diff/#



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to