[ https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14506365#comment-14506365 ]
Chris Nauroth commented on ZOOKEEPER-2174: ------------------------------------------ I reviewed the Jenkins output and checked for the tests that I've been seeing logged as failures erroneously by the runner. These are no longer logging the failure message, so it appears this patch had the desired effect. > JUnit4ZKTestRunner logs test failure for all exceptions even if the test > method is annotated with an expected exception. > ------------------------------------------------------------------------------------------------------------------------ > > Key: ZOOKEEPER-2174 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174 > Project: ZooKeeper > Issue Type: Bug > Components: tests > Reporter: Chris Nauroth > Assignee: Chris Nauroth > Priority: Minor > Attachments: ZOOKEEPER-2174.001.patch > > > {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any > exception is thrown, it logs a message stating that the test failed. > However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to > indicate that an exception is the expected result, and thus the test passes. > The runner should be aware of expected exceptions and only log if an > unexpected exception occurs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)