[
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507555#comment-14507555
]
Hongchao Deng commented on ZOOKEEPER-2174:
------------------------------------------
Thanks for the code, [~cnauroth]!
Two nits:
1. can you add some comments so it's easier to understand?
2. add a logging when expected exception gets caught
> JUnit4ZKTestRunner logs test failure for all exceptions even if the test
> method is annotated with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2174
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
> Project: ZooKeeper
> Issue Type: Bug
> Components: tests
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Attachments: ZOOKEEPER-2174.001.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any
> exception is thrown, it logs a message stating that the test failed.
> However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to
> indicate that an exception is the expected result, and thus the test passes.
> The runner should be aware of expected exceptions and only log if an
> unexpected exception occurs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
