[jira] [Commented] (ZOOKEEPER-2174) JUnit4ZKTestRunner logs test failure for all exceptions even if the test method is annotated with an expected exception.

[Rakesh R (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14508399#comment-14508399
 ] 

Rakesh R commented on ZOOKEEPER-2174:
-------------------------------------

Thanks [~cnauroth] for correcting all the cases.
bq. slf4j doesn't offer a method that accepts both a parameterized message and 
an exception at the same time.
I could see similar usage in the project and it seems working fine. What do you 
say?

{{StaticHostProvider.java}}
{code}
            } catch (UnknownHostException ex) {
                LOG.warn("No IP address found for server: {}", address, ex);
            }
{code}

> JUnit4ZKTestRunner logs test failure for all exceptions even if the test 
> method is annotated with an expected exception.
> ------------------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2174
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2174
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>             Fix For: 3.4.7, 3.5.2, 3.6.0
>
>         Attachments: ZOOKEEPER-2174.001.patch, ZOOKEEPER-2174.002.patch, 
> ZOOKEEPER-2174.003.patch
>
>
> {{JUnit4ZKTestRunner}} wraps JUnit test method execution, and if any 
> exception is thrown, it logs a message stating that the test failed.  
> However, some ZooKeeper tests are annotated with {{@Test(expected=...)}} to 
> indicate that an exception is the expected result, and thus the test passes.  
> The runner should be aware of expected exceptions and only log if an 
> unexpected exception occurs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)