[
https://issues.apache.org/jira/browse/ZOOKEEPER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526624#comment-14526624
]
Vitaly Stakhovsky commented on ZOOKEEPER-2096:
----------------------------------------------
Not sure how to respond to this, so I put it here:
This patch affects only Windows. It builds fine on MSVC++ 2010, 2013.
And there were no complaints from automated builds.
As for the runtime behavior, I can tell from experience that without this fix
the code would not work at all.
This could be established immediately should there be any automated tests for
Windows.
> C client builds with incorrect error codes in VisualStudio 2010+
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-2096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2096
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, c client
> Environment: Windows MSVS 2010+
> Reporter: Vitaly Stakhovsky
> Attachments: ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch,
> ZOOKEEPER-2096.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> It reports:
> warning C4005: 'EWOULDBLOCK' : macro redefinition
> warning C4005: 'EINPROGRESS' : macro redefinition
> In MSVS 2010+, these constants are now in <errno.h>.
> What's worse, they have different numeric values.
> Possible fix:
> In "src/c/include/winconfig.h" :
> #if _MSC_VER < 1600
> #define EWOULDBLOCK WSAEWOULDBLOCK
> #define EINPROGRESS WSAEINPROGRESS
> #endif
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
