[
https://issues.apache.org/jira/browse/ZOOKEEPER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569710#comment-14569710
]
Hadoop QA commented on ZOOKEEPER-2096:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12737000/ZOOKEEPER-2096.patch.branch34
against trunk revision 1683163.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2743//console
This message is automatically generated.
> C client builds with incorrect error codes in VisualStudio 2010+
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-2096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2096
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.4.6, 3.5.0
> Environment: Windows MSVS 2010+
> Reporter: Vitaly Stakhovsky
> Fix For: 3.4.7, 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch,
> ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch,
> ZOOKEEPER-2096.patch.branch34
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> It reports:
> warning C4005: 'EWOULDBLOCK' : macro redefinition
> warning C4005: 'EINPROGRESS' : macro redefinition
> In MSVS 2010+, these constants are now in <errno.h>.
> What's worse, they have different numeric values.
> Possible fix:
> In "src/c/include/winconfig.h" :
> #if _MSC_VER < 1600
> #define EWOULDBLOCK WSAEWOULDBLOCK
> #define EINPROGRESS WSAEINPROGRESS
> #endif
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
