[
https://issues.apache.org/jira/browse/ZOOKEEPER-2096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14569603#comment-14569603
]
Raul Gutierrez Segales commented on ZOOKEEPER-2096:
---------------------------------------------------
[~vvs], [~iandi]: merged for 3.5 and trunk (respectively):
https://github.com/apache/zookeeper/commit/87c7a0c71bac8b30b84777680ae0cc91aea930b2
https://github.com/apache/zookeeper/commit/98a3cabfa279833b81908d72f1c10ee9f598a045
Thought it doesn't apply cleanly to the 3.4 branch — do you mind backporting
this for that branch? Thanks!
> C client builds with incorrect error codes in VisualStudio 2010+
> ----------------------------------------------------------------
>
> Key: ZOOKEEPER-2096
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2096
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, c client
> Affects Versions: 3.4.6, 3.5.0
> Environment: Windows MSVS 2010+
> Reporter: Vitaly Stakhovsky
> Fix For: 3.4.7, 3.5.1, 3.6.0
>
> Attachments: ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch,
> ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch, ZOOKEEPER-2096.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> It reports:
> warning C4005: 'EWOULDBLOCK' : macro redefinition
> warning C4005: 'EINPROGRESS' : macro redefinition
> In MSVS 2010+, these constants are now in <errno.h>.
> What's worse, they have different numeric values.
> Possible fix:
> In "src/c/include/winconfig.h" :
> #if _MSC_VER < 1600
> #define EWOULDBLOCK WSAEWOULDBLOCK
> #define EINPROGRESS WSAEINPROGRESS
> #endif
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
