----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review87114 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139438> remove the extra whitespaces/tabs (i.e.: the red part in the RB). src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139439> sounds like myAddrs could be constructed and saved from the constructor, to avoid building it on every call, no? src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139440> typo, excludedSpecialAddress src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139441> whitespace/tabs - Raul Gutierrez Segales On June 8, 2015, 9:44 a.m., Yasuhito Fukuda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35204/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 9:44 a.m.) > > > Review request for zookeeper. > > > Bugs: ZOOKEEPER-2193 > https://issues.apache.org/jira/browse/ZOOKEEPER-2193 > > > Repository: zookeeper-git > > > Description > ------- > > See ZOOKEEPER-2193 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 73fa4e67a09806c90a6037d9a170179cb806b896 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java > f15f831701f9c8514db5003ebd550cd3880b48c7 > > Diff: https://reviews.apache.org/r/35204/diff/ > > > Testing > ------- > > > Thanks, > > Yasuhito Fukuda > >
