> On 6月 9, 2015, 10:12 a.m., Raul Gutierrez Segales wrote: > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java, line 304 > > <https://reviews.apache.org/r/35204/diff/1/?file=980620#file980620line304> > > > > sounds like myAddrs could be constructed and saved from the > > constructor, to avoid building it on every call, no?
Yes indeed! myAddr will construct in the constructor. at the same time, I modified constructor overloading in QuorumPeer class. - Yasuhito ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review87114 ----------------------------------------------------------- On 6月 9, 2015, 3:45 p.m., Yasuhito Fukuda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35204/ > ----------------------------------------------------------- > > (Updated 6月 9, 2015, 3:45 p.m.) > > > Review request for zookeeper. > > > Bugs: ZOOKEEPER-2193 > https://issues.apache.org/jira/browse/ZOOKEEPER-2193 > > > Repository: zookeeper-git > > > Description > ------- > > See ZOOKEEPER-2193 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 73fa4e67a09806c90a6037d9a170179cb806b896 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java > f15f831701f9c8514db5003ebd550cd3880b48c7 > > Diff: https://reviews.apache.org/r/35204/diff/ > > > Testing > ------- > > > Thanks, > > Yasuhito Fukuda > >
