----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35204/#review87340 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139674> this'll override the default type which is Participant: ```java public LearnerType type = LearnerType.PARTICIPANT; ``` so this should pass LearnerType.Participant instead of null. src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139675> ditto src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139676> ditto src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139677> to avoid duplicating this code you could probably call the constructor from below here and just move the setType call to after the constructor, i.e.: ```java this(sid, addr, clientAddr, electionAddr, Participant); if (serverParts.length == 4) { setType(serverParts[3]); } ``` src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139678> nit: using String.format to build strings makes it easier to grep them afterwards src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139672> this method doesn't have to be public. src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java <https://reviews.apache.org/r/35204/#comment139673> don't call new InetSocketAddress(0) from within the loop; do it once outside and use that. - Raul Gutierrez Segales On June 9, 2015, 6:45 a.m., Yasuhito Fukuda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35204/ > ----------------------------------------------------------- > > (Updated June 9, 2015, 6:45 a.m.) > > > Review request for zookeeper. > > > Bugs: ZOOKEEPER-2193 > https://issues.apache.org/jira/browse/ZOOKEEPER-2193 > > > Repository: zookeeper-git > > > Description > ------- > > See ZOOKEEPER-2193 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java > 73fa4e67a09806c90a6037d9a170179cb806b896 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java > f15f831701f9c8514db5003ebd550cd3880b48c7 > > Diff: https://reviews.apache.org/r/35204/diff/ > > > Testing > ------- > > > Thanks, > > Yasuhito Fukuda > >
