[jira] [Commented] (ZOOKEEPER-2223) support method-level JUnit testcase

[Akihiro Suda (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616165#comment-14616165
 ] 

Akihiro Suda commented on ZOOKEEPER-2223:
-----------------------------------------

Hi, [~rgs] 

Thank your a lot for reviewing!

The second parameter of {{computeTestMethodsForClass}} stands for the list of 
default methods that is used when no {{test.method}} is specified.

I updated patch ( {{ZOOKEEPER-2223-v4.patch}} ) so as to clarify the meaning as 
follows:
{code}
-    public static List<FrameworkMethod> computeTestMethodsForClass(Class 
klass, List<FrameworkMethod> list) {
+    public static List<FrameworkMethod> computeTestMethodsForClass(final Class 
klass, final List<FrameworkMethod> defaultMethods) {
+        List<FrameworkMethod> list = defaultMethods;
         String methodName = System.getProperty("test.method");
         if (methodName == null) {
-            LOG.info("No test.method specified");
+            LOG.info("No test.method specified. using default methods.");
         } else {
             LOG.info("Picked up test.method={}", methodName);
             try {
{code}


> support method-level JUnit testcase
> -----------------------------------
>
>                 Key: ZOOKEEPER-2223
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2223
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Akihiro Suda
>            Assignee: Akihiro Suda
>            Priority: Minor
>         Attachments: ZOOKEEPER-2223-v2.patch, ZOOKEEPER-2223-v3.patch, 
> ZOOKEEPER-2223-v4.patch, ZOOKEEPER-2223.patch
>
>
> Currently, a user can execute class-level single test, but cannot execute 
> method-level ones.
> This patch adds a support for method-level single test so as to facilitate 
> ease of debugging failing tests (like ZOOKEEPER-2080).
> Class-level test (exists in current version)
> {panel}
> $ ant -Dtestcase=ReconfigRecoveryTest test-core-java
> {panel}
> Method-level test (proposal)
> {panel}
> $ ant -Dtestcase=ReconfigRecoveryTest 
> -Dtest.method=testCurrentObserverIsParticipantInNewConfig test-core-java
> {panel}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)