Hm, the kafka workflow looks pretty thorough. Includes jenkins integration which is promising.
Patrick On Tue, Aug 30, 2016 at 8:16 AM, Benjamin Reed <[email protected]> wrote: > i like kafka's contributor work flow! > https://cwiki.apache.org/confluence/display/KAFKA/ > Contributing+Code+Changes > i'd like to head toward that. of course there are other options as well, > but as pat points out the first phase is moving to git. > > > On Tue, Aug 30, 2016 at 5:37 AM, Flavio Junqueira <[email protected]> wrote: > > > > > > On 30 Aug 2016, at 07:42, Benjamin Reed <[email protected]> wrote: > > > > > > i'm curious, can we get the qa > > > bot to trigger off a pull request? > > > > Yes, we can. See this Kafka build queue: > > > > https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/ < > > https://builds.apache.org/job/kafka-trunk-git-pr-jdk7/> > > > > -Flavio > > > > > > > > On Mon, Aug 29, 2016 at 8:56 PM, Patrick Hunt <[email protected]> > wrote: > > > > > >> On Mon, Aug 29, 2016 at 8:48 AM, Benjamin Reed <[email protected]> > > wrote: > > >> > > >>> gerritt is pretty amazing. after you upload a patch, the whole life > > cycle > > >>> of review, verification, and committer committing can happen on the > > web. > > >> in > > >>> practice it means that reviewing and committing small correct changes > > >>> becomes two clicks of a button. but, this is not what i'm proposing. > > >>> talking with pat there is no clear way to get gerritt setup. kudo > uses > > >> it, > > >>> but it's a one off that we can't really leverage. > > >>> > > >>> in moving to git we can enable more flexible workflows that get us > > closer > > >>> to the benefits of using something like gerritt. for example, other > > >> apache > > >>> projects use workflows that allows patch uploads and reviewing to > > happen > > >> as > > >>> git pull requests. i realize it is subjective, which is why it's good > > >> that > > >>> others share their opinions; in my experience working on a variety of > > >>> different projects with different contribution systems, i've found > that > > >> the > > >>> jira based patch uploading to be cumbersome for the contributor, > > >> reviewer, > > >>> and committer. even just the simple start of moving to git and > > accepting > > >>> github pull requests as a method of contribution will improve things > a > > >> lot. > > >>> > > >>> as far as who does the work: pat mentioned that he has looked into > this > > >> and > > >>> has the skillz to make it happen. > > >>> > > >>> > > >> I am pretty sure I know how to get INFRA to make the switch from > > svn->git. > > >> However there are additional changes we'll need to make (e.g. updating > > the > > >> "how to release" process, patch submission process, etc...) that we'll > > have > > >> to handle together. > > >> > > >> Gerrit is not something that INFRA is supporting at this time. As such > > >> we'll either have to continue to use RB or collectively agree to > > something > > >> else. Also keep in mind that qabot triggers off JIRA patches, we don't > > want > > >> to lose that. > > >> > > >> This thread is "switch to git", I'd recommend we focus on one step at > a > > >> time. That said it might be good to lay out some steps before we start > > >> making changes. > > >> > > >> Patrick > > >> > > >> > > >>> ben > > >>> > > >>> On Mon, Aug 29, 2016 at 7:33 AM, Flavio Junqueira <[email protected]> > > >> wrote: > > >>> > > >>>> I also don't know what's being proposed here exactly. I thought Ben > > was > > >>>> just pointing out that it'd be nice to improve our infrastructure > and > > >>>> tooling. > > >>>> > > >>>> In any case, I wanted to point to a thread in which we have some > > >>>> discussion around moving to git and doing github pull requests along > > >> with > > >>>> some pointers that this was done in other projects, like BookKeeper > > and > > >>>> Kafka: > > >>>> > > >>>> http://mail-archives.apache.org/mod_mbox/zookeeper-dev/ > > >>>> 201603.mbox/%3cCANLc_9L4kygfgXX4u-C33ccohtauNYpKExRHwUgJMHCkAws- > > >>>> [email protected]%3e <http://mail-archives.apache. > > >>>> org/mod_mbox/zookeeper-dev/201603.mbox/%3CCANLc_9L4kygfgXX4u- > > >>>> [email protected]%3E> > > >>>> > > >>>> I don't have experience with gerritt and I have see only one project > > >>>> referring to gerritt in Apache: Kudo. > > >>>> > > >>>> -Flavio > > >>>> > > >>>>> On 29 Aug 2016, at 14:25, Camille Fournier <[email protected]> > > >> wrote: > > >>>>> > > >>>>> I'm confused what is the actual work that needs to happen to > finalize > > >>>> this > > >>>>> and who is going to do that work? Ben are you volunteering or is > > >> there > > >>>>> nothing left to do? > > >>>>> > > >>>>> On Aug 28, 2016 10:54 PM, "Patrick Hunt" <[email protected]> wrote: > > >>>>> > > >>>>>> :-) > > >>>>>> > > >>>>>> In order to make it "official" my recommendation would be for you > to > > >>>> start > > >>>>>> a VOTE thread on dev@ after a couple more days, if there are no > > >>>> objections > > >>>>>> here that is. > > >>>>>> > > >>>>>> Regards, > > >>>>>> > > >>>>>> Patrick > > >>>>>> > > >>>>>> > > >>>>>> On Sat, Aug 27, 2016 at 1:38 PM, Benjamin Reed <[email protected]> > > >>>> wrote: > > >>>>>> > > >>>>>>> haha! i'm just seconding your original proposal from many years > > >> ago! > > >>>>>>> > > >>>>>>> On Fri, Aug 26, 2016 at 6:15 PM, Patrick Hunt <[email protected]> > > >>>> wrote: > > >>>>>>> > > >>>>>>>> I really love it when the new guy shows up and immediately > > >> requests > > >>>>>> tool > > >>>>>>>> changes. ;-) > > >>>>>>>> > > >>>>>>>> afaik given we have a git mirror already, moving to git from an > > >>> infra > > >>>>>>>> perspective is pretty straightforward. Definitely some impact in > > >>> some > > >>>>>>> other > > >>>>>>>> areas (like cutting a release) but we should be able to chase > > >> those > > >>>>>> down. > > >>>>>>>> > > >>>>>>>> +1 from me. > > >>>>>>>> > > >>>>>>>> Patrick > > >>>>>>>> > > >>>>>>>> On Fri, Aug 26, 2016 at 11:36 AM, Michael Han < > [email protected]> > > >>>>>> wrote: > > >>>>>>>> > > >>>>>>>>> +1! > > >>>>>>>>> > > >>>>>>>>> On Fri, Aug 26, 2016 at 11:34 AM, Edward Ribeiro < > > >>>>>>>> [email protected] > > >>>>>>>>>> > > >>>>>>>>> wrote: > > >>>>>>>>> > > >>>>>>>>>> +1 :+D > > >>>>>>>>>> > > >>>>>>>>>> Em 26 de ago de 2016 2:37 PM, "Raúl Gutiérrez Segalés" < > > >>>>>>>>>> [email protected]> > > >>>>>>>>>> escreveu: > > >>>>>>>>>> > > >>>>>>>>>>> On 26 August 2016 at 10:35, Benjamin Reed <[email protected]> > > >>>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>>> i'm starting to get back into zk development :) i'm a bit > > >>>>>>>> distressed > > >>>>>>>>>> that > > >>>>>>>>>>>> we are still using svn and patches managed by jiras. i've > > >>>>>> gotten > > >>>>>>>>>>> extremely > > >>>>>>>>>>>> spoiled by gerritt and phabricator over the years! > > >>>>>>>>>>>> > > >>>>>>>>>>>> as a first step to more efficient workflows for contributors > > >>>>>> and > > >>>>>>>>>>> committers > > >>>>>>>>>>>> can we move to git? i had an offline conversation with pat > and > > >>>>>> he > > >>>>>>>>> knows > > >>>>>>>>>>> how > > >>>>>>>>>>>> to flip the switch. > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> big +1 > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> -rgs > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> -- > > >>>>>>>>> Cheers > > >>>>>>>>> Michael. > > >>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>> > > >>>> > > >>> > > >> > > > > >
