Patrick Hunt commented on ZOOKEEPER-2578:

Hi [~bjorn...@gmail.com] - perhaps I'm missing something but I believe the 
intent was for the user to provide (if they want to override either/both) 
ZOOCFGDIR and ZOOCFG. Where ZOOCFGDIR is the location of the cfg file, and 
ZOOCFG is the name of the config file at ZOOCFGDIR. As such the current logic 
seems right to me. What limitation/issue do you see with this? Other than the 
obvious - you might need to specify both ZOOCFGDIR and ZOOCFG rather than just 
specifying ZOOCFG as an absolute path, including the cfg file name.

> zkEnv.sh does not set $ZOOCFG properly if already set 
> ------------------------------------------------------
>                 Key: ZOOKEEPER-2578
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2578
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.3.0, 3.3.1, 3.3.2, 3.3.3, 
> 3.3.4, 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.3.5, 3.3.6, 3.4.4, 3.4.5, 3.4.6, 3.4.7, 
> 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2
>            Reporter: Bjorn Stange
>         Attachments: ZOOKEEPER-2578.patch
> In bin/zkEnv.sh The ZOOCFG variable is duplicated over itself if already set. 
> For example, in my use case it was being set in zookeeper-env.sh. The problem 
> seems to arise from this line (line 61 on the master branch at the time of 
> this submission): ZOOCFG="$ZOOCFGDIR/$ZOOCFG". This overwrites the value of 
> ZOOCFG by appending the old value to the value of ZOOCFGDIR, which is 
> problematic if it was already initialized as the absolute path to a file. The 
> behavior of overwriting the value of the variable in this way seems to be 
> specific to the case where ZOOCFG is not initialized. The final state of 
> ZOOCFG seemingly is the absolute path to the zookeeper configuration file. 
> This behavior assumes that it is the filename only, which is where the bug 
> arises. 

This message was sent by Atlassian JIRA

Reply via email to