[
https://issues.apache.org/jira/browse/ZOOKEEPER-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510185#comment-15510185
]
Patrick Hunt commented on ZOOKEEPER-2578:
-----------------------------------------
I agree it's not as clear as it could be - took me a bit to figure out what the
script was trying to do in order to respond to this JIRA. I would say if you
are interested to address then what you are saying would make sense - a third
variable of some kind. Mainly we don't want to change the existing
functionality, i.e. the changes should be b/w compat from a user perspective.
I'd also recommend updating (adding) the comments in the file to be more clear
(for the next person that comes along and has similar questions....). Thanks
Bjorn!
> zkEnv.sh does not set $ZOOCFG properly if already set
> ------------------------------------------------------
>
> Key: ZOOKEEPER-2578
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2578
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.3.0, 3.3.1, 3.3.2, 3.3.3,
> 3.3.4, 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.3.5, 3.3.6, 3.4.4, 3.4.5, 3.4.6, 3.4.7,
> 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2
> Reporter: Bjorn Stange
> Attachments: ZOOKEEPER-2578.patch
>
>
> In bin/zkEnv.sh The ZOOCFG variable is duplicated over itself if already set.
> For example, in my use case it was being set in zookeeper-env.sh. The problem
> seems to arise from this line (line 61 on the master branch at the time of
> this submission): ZOOCFG="$ZOOCFGDIR/$ZOOCFG". This overwrites the value of
> ZOOCFG by appending the old value to the value of ZOOCFGDIR, which is
> problematic if it was already initialized as the absolute path to a file. The
> behavior of overwriting the value of the variable in this way seems to be
> specific to the case where ZOOCFG is not initialized. The final state of
> ZOOCFG seemingly is the absolute path to the zookeeper configuration file.
> This behavior assumes that it is the filename only, which is where the bug
> arises.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
