Bjorn Stange commented on ZOOKEEPER-2578:

The issue is that ZOOCFG changes to become the absolute path to the config file 
and that is what the scripts expect it to be but it starts out (if left empty) 
as just the filename. I find that confusing because it has drastically 
different starting and ending states. Is it supposed to be the absolute path? 
Is it supposed to be the filename? 

Otherwise, I do see your point. I was trying to override the final state of 
ZOOCFG in zookeeper-env.sh and not the intermediate state, and doing what you 
suggest would indeed work. Perhaps using a third variable for the absolute path 
to the config file would reduce ambiguity here as well? I was just confused by 
the way this variable was being handled and thought I'd open a discussion 
around it.

> zkEnv.sh does not set $ZOOCFG properly if already set 
> ------------------------------------------------------
>                 Key: ZOOKEEPER-2578
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2578
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.3.0, 3.3.1, 3.3.2, 3.3.3, 
> 3.3.4, 3.4.0, 3.4.1, 3.4.2, 3.4.3, 3.3.5, 3.3.6, 3.4.4, 3.4.5, 3.4.6, 3.4.7, 
> 3.4.8, 3.4.9, 3.4.10, 3.5.0, 3.5.1, 3.5.2
>            Reporter: Bjorn Stange
>         Attachments: ZOOKEEPER-2578.patch
> In bin/zkEnv.sh The ZOOCFG variable is duplicated over itself if already set. 
> For example, in my use case it was being set in zookeeper-env.sh. The problem 
> seems to arise from this line (line 61 on the master branch at the time of 
> this submission): ZOOCFG="$ZOOCFGDIR/$ZOOCFG". This overwrites the value of 
> ZOOCFG by appending the old value to the value of ZOOCFGDIR, which is 
> problematic if it was already initialized as the absolute path to a file. The 
> behavior of overwriting the value of the variable in this way seems to be 
> specific to the case where ZOOCFG is not initialized. The final state of 
> ZOOCFG seemingly is the absolute path to the zookeeper configuration file. 
> This behavior assumes that it is the filename only, which is where the bug 
> arises. 

This message was sent by Atlassian JIRA

Reply via email to