GitHub user hanm opened a pull request:

    https://github.com/apache/zookeeper/pull/140

    ZOOKEEPER-2565: Fix ServerConfigTest#testValidArguments test case.

    ServerConfig.getDataDir returns type String in branch-3.4 but return type 
File in branch-3.5 and master. So we need to deal with this difference 
accordingly in our test.
    
    This PR is intended to be merged in master, branch-3.5, and branch-3.4.
    
    @rakeshadr PTAL


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2565

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit 48f099c5419ff526934a7c7ff7c0d89ced970e09
Author: Michael Han <[email protected]>
Date:   2017-01-03T22:29:39Z

    ZOOKEEPER-2565: Fix ServerConfigTest#testValidArguments test case failures 
for both branch-3.4 and branch-3.5, master.
    ServerConfig.getDataDir returns type String in branch-3.4 but return type 
File in branch-3.5 and master. So we need to deal with this difference 
accordingly in our test.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to