Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/140#discussion_r94507355
--- Diff: src/java/test/org/apache/zookeeper/ServerConfigTest.java ---
@@ -57,4 +59,16 @@ public void testTooManyArguments() {
String[] args = {"2181", "/data/dir", "60000", "10000", "9999"};
serverConfig.parse(args);
}
-}
+
+ boolean checkEquality(String a, String b) {
+ return a != null && a.equals(b);
+ }
+
+ boolean checkEquality(String a, File b) {
+ try {
+ return a != null && b != null && new
File(a).getCanonicalPath().equals(b.getCanonicalPath());
+ } catch (IOException e) {
--- End diff --
Why not let this method throw ``IOException`` and change the caller
accordingly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
