Github user hanm commented on the issue: https://github.com/apache/zookeeper/pull/140 @eribeiro Yeah, I read about the difference but I think in our context it is pretty safe to use File.equals given the actual string literal returned from getDataDir and the string it compares against would be exact the same (so the corner cases does not apply here). Initially I used getCanonicalPath for safety but since you brought this up and I thought about it, I feel it's OK. Do you see any practical failure cases that we would run into here by using File.equals?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---