Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/322#discussion_r130567289
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr,
Record txn)
LOG.warn("Current zxid " + hdr.getZxid()
--- End diff --
I think:
```
if (hdr == null) return false;
/**/
return true;
```
may be better,to avoid too deep if-else nest
BTW,why do I see so many flaky changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
