Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/322#discussion_r131053635
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr,
Record txn)
LOG.warn("Current zxid " + hdr.getZxid()
--- End diff --
I would recommend make the early return changes here as the changes to be
made is small and they are not hard to review. When we say "do it separately"
in the context of zk, it probably implies "never" <grin>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
