Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/322#discussion_r131049471
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -199,14 +199,16 @@ public synchronized boolean append(TxnHeader hdr,
Record txn)
LOG.warn("Current zxid " + hdr.getZxid()
--- End diff --
I like the suggestion here. Though ZK does not enforce such style, early
exists is my preference for reasons documented here:
https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
Though this change can be done separately as it's not an existing stylish
issue.
>> BTW,why do I see so many flaky changes?
Not sure about what flaky changes you are referring to? @maoling
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
