[GitHub] zookeeper pull request #430: ZOOKEEPER-2893. very poor choice of logging if ...

[anmolnar]

Github user anmolnar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/430#discussion_r156597536
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1232,11 +1233,12 @@ public void run() {
                             } else if (e instanceof RWServerFoundException) {
                                 LOG.info(e.getMessage());
                             } else {
    +                            SocketAddress remoteAddr = 
clientCnxnSocket.getRemoteSocketAddress();
                                 LOG.warn(
                                         "Session 0x"
                                                 + 
Long.toHexString(getSessionId())
                                                 + " for server "
    -                                            + 
clientCnxnSocket.getRemoteSocketAddress()
    +                                            + (remoteAddr == null ? addr : 
remoteAddr)
    --- End diff --
    
    Makes sense. I'll just use 'addr' here.


---