Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/430#discussion_r156952287
--- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
@@ -1236,7 +1237,7 @@ public void run() {
"Session 0x"
+
Long.toHexString(getSessionId())
+ " for server "
- +
clientCnxnSocket.getRemoteSocketAddress()
+ + serverAddress
+ ", unexpected error"
+ RETRY_CONN_MSG, e);
--- End diff --
We're talking about the same thing in the Jira. It's arguable which
exception should be logged at INFO level without the stack trace, I ended up
separating SocketExceptions altogether and leaving the rest for the original
handler.
---