Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/430#discussion_r156825263
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1236,7 +1237,7 @@ public void run() {
                                         "Session 0x"
                                                 + 
Long.toHexString(getSessionId())
                                                 + " for server "
    -                                            + 
clientCnxnSocket.getRemoteSocketAddress()
    +                                            + serverAddress
                                                 + ", unexpected error"
                                                 + RETRY_CONN_MSG, e);
    --- End diff --
    
    I think it would be good to address the other issue Paul mentioned - no 
need to dump a stack if we know this is NoRouteToHostException - why wouldn't 
we add another elseif to check for this type?


---

Reply via email to