[
https://issues.apache.org/jira/browse/ZOOKEEPER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317852#comment-16317852
]
Hadoop QA commented on ZOOKEEPER-1580:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1401//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1401//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1401//console
This message is automatically generated.
> QuorumPeer.setRunning is not used
> ---------------------------------
>
> Key: ZOOKEEPER-1580
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1580
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
>
> setRunning is a public method and a search did not indicate that it is used
> anywhere, not even in tests. In fact, I believe we should not change
> "running" freely and we should only do it when calling shutdown.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
