[
https://issues.apache.org/jira/browse/ZOOKEEPER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341109#comment-16341109
]
ASF GitHub Bot commented on ZOOKEEPER-1580:
-------------------------------------------
GitHub user maoling opened a pull request:
https://github.com/apache/zookeeper/pull/452
ZOOKEEPER-1580:QuorumPeer.setRunning is not used
- more details in
[JIRA:ZOOKEEPER-1580](https://issues.apache.org/jira/browse/ZOOKEEPER-1580)
- I forget fetching the upstream codes, make a mistake in the origin
[PR-446] (https://github.com/apache/zookeeper/pull/446) which includes some
review history,so I close it and open a new one
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maoling/zookeeper ZOOKEEPER-1580
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/452.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #452
----
commit 28de1e88fb54ddd783e00dd96a777af3e1e6f36e
Author: maoling <maoling199210191@...>
Date: 2018-01-09T06:22:04Z
ZOOKEEPER-1580:QuorumPeer.setRunning is not used
commit 29a5aba1e7b354797170b7e61fabd9b51a1ddfd1
Author: maoling <maoling199210191@...>
Date: 2018-01-26T13:46:28Z
remove the setter and return back to setting the running field directly
----
> QuorumPeer.setRunning is not used
> ---------------------------------
>
> Key: ZOOKEEPER-1580
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1580
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
>
> setRunning is a public method and a search did not indicate that it is used
> anywhere, not even in tests. In fact, I believe we should not change
> "running" freely and we should only do it when calling shutdown.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
