[
https://issues.apache.org/jira/browse/ZOOKEEPER-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319621#comment-16319621
]
ASF GitHub Bot commented on ZOOKEEPER-1580:
-------------------------------------------
Github user maoling commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/446#discussion_r160580471
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1751,7 +1751,7 @@ public synchronized void initConfigInZKDatabase() {
if (zkDb != null) zkDb.initConfigInZKDatabase(getQuorumVerifier());
}
- public void setRunning(boolean running) {
+ private void setRunning(boolean running) {
--- End diff --
I'm also ambiguous about this change.could you give me some your insight?
> QuorumPeer.setRunning is not used
> ---------------------------------
>
> Key: ZOOKEEPER-1580
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1580
> Project: ZooKeeper
> Issue Type: Bug
> Reporter: Flavio Junqueira
> Assignee: Flavio Junqueira
> Priority: Minor
>
> setRunning is a public method and a search did not indicate that it is used
> anywhere, not even in tests. In fact, I believe we should not change
> "running" freely and we should only do it when calling shutdown.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
