Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/453#discussion_r167838309
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/LearnerHandlerTest.java ---
@@ -462,6 +469,8 @@ public void testNewEpochZxid() throws Exception {
// Peer has zxid of epoch 1
peerZxid = getZxid(1, 0);
+ //We are on a different epoch so we don't know 1, 0 is in our log
or not.
+ // So we need to do a full SNAP
--- End diff --
I think this comment has been added by mistake. You added (1,0) to the log
above, hence syncFollower() returns false which means we don't need to do full
SNAP.
---
