[GitHub] zookeeper pull request #601: WIP - ZOOKEEPER-3123 MetricsProvider Lifecycle ...

[lvfangmin]

Github user lvfangmin commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/601#discussion_r212526680
  
    --- Diff: 
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
    @@ -159,6 +173,7 @@ public void runFromConfig(QuorumPeerConfig config)
               }
     
               quorumPeer = getQuorumPeer();
    +          
quorumPeer.setRootMetricsContext(metricsProvider.getRootContext());
    --- End diff --
    
    I think we need to pass in metricsProvider to QuorumPeer, right? Because we 
need to stop the metricsProvider in QuorumPeer.shutdown.


---