Github user lvfangmin commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r212527464
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java ---
@@ -325,6 +327,8 @@ public void parseProperties(Properties zkProp)
quorumServicePrincipal = value;
} else if (key.equals("quorum.cnxn.threads.size")) {
quorumCnxnThreadsSize = Integer.parseInt(value);
+ } else if (key.equals("metricsProvider.className")) {
--- End diff --
What's the preference between JVM property and the property in config file?
It looks like have a provider name JVM option in MetricsProviderBootstrap is
simpler?
---
