Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/601#discussion_r213001935
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java ---
@@ -159,6 +173,7 @@ public void runFromConfig(QuorumPeerConfig config)
}
quorumPeer = getQuorumPeer();
+
quorumPeer.setRootMetricsContext(metricsProvider.getRootContext());
--- End diff --
No, MetricsProvider will be stopped in the finally block, it is better that
QuorumPeerMain creates, starts and stops it
---
