ivmaykov commented on a change in pull request #753: ZOOKEEPER-3204: Reconfig
tests are constantly failing on 3.5 after applying Java 11 fix
URL: https://github.com/apache/zookeeper/pull/753#discussion_r254334426
##########
File path:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
##########
@@ -291,33 +355,36 @@ private void doWrite(List<Packet> pendingQueue, Packet
p, ClientCnxn cnxn) {
pendingQueue.add(p);
}
}
- sendPkt(p);
+ sendPktOnly(p);
}
if (outgoingQueue.isEmpty()) {
break;
}
p = outgoingQueue.remove();
}
+ // TODO: maybe we should flush in the loop above every N packets/bytes?
+ // But, how do we determine the right value for N ...
Review comment:
not as part of `channelRead()`. It's called from `doTransport()`, which is
called in a loop in `ClientCnxn.SendThread.run()`. This is code that's trying
to unify the NIO and Netty behavior, but the code was written with NIO in mind
so maybe it's not the best fit for Netty. Seems to work though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
