Thank you. I'll look into these also and recut a candidate once all pending items are done.
Best, tison. Kezhu Wang <kez...@gmail.com> 于2025年5月11日周日 11:12写道： > -1 non binding > > The ZOO_VERSION in zookeeper_version.h is 3.9.3 still[1]. The built c > cli outputs "Version: ZooKeeper cli (c client) version 3.9.3". > > See also ZOOKEEPER-4928[2]. > > [1]: > https://github.com/apache/zookeeper/blob/release-3.9.4-0/zookeeper-client/zookeeper-client-c/include/zookeeper_version.h > [2]: https://issues.apache.org/jira/browse/ZOOKEEPER-4928 > > Best, > Kezhu Wang > > On Wed, May 7, 2025 at 11:57 AM tison <wander4...@gmail.com> wrote: > > > > Sounds reasonable. I'd leave this thread open for a while for further > > feedback. > > > > Will take a look at the related patch. > > > > Best, > > tison. > > > > > > Kezhu Wang <kez...@gmail.com> 于2025年5月7日周三 00:33写道： > > > > > Hi tison, > > > > > > Thank you for driving this! > > > > > > I would expect that there is an email to discuss what else is left for > > > the next release. > > > > > > I saw two candidates for the next release. > > > > > > 1. ZOOKEEPER-4921[1][2] partially rollback ZOOKEEPER-4508[3] to keep > > > consistent with versions prior to 3.9.3 (excluded). I authored a dev > > > mail[4] for this. Given that it is a rollback, I would like to see it > > > in the next release so no more releases have the rollbacked behavior. > > > 2. ZOOKEEPER-4925[5][6] fixed a data loss introduced in 3.9.3. From my > > > point of view, this data loss is easy to trigger, so I would like to > > > see it shipped in the next release. > > > > > > [1]: https://issues.apache.org/jira/browse/ZOOKEEPER-4921 > > > [2]: https://github.com/apache/zookeeper/pull/2252 > > > [3]: https://issues.apache.org/jira/browse/ZOOKEEPER-4508 > > > [4]: https://lists.apache.org/thread/nfb9z7rhgglbjzfxvg4z2m3pks53b3c1 > > > [5]: https://issues.apache.org/jira/browse/ZOOKEEPER-4925 > > > [6]: https://github.com/apache/zookeeper/pull/2254 > > > > > > Best, > > > Kezhu Wang > > > > > > On Tue, May 6, 2025 at 6:18 PM tison <wander4...@gmail.com> wrote: > > > > > > > > This is a release candidate for 3.9.4. > > > > > > > > This is a minor release. The full release notes is available at: > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12355230&styleName=Html&projectId=12310801 > > > > > > > > *** Please download, test and vote by May 14th 2025, 23:59 UTC+0. *** > > > > > > > > Source files: > > > > > > > > https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.4-candidate-0 > > > > / > > > > > > > > Maven staging repo: > > > > > > > > https://repository.apache.org/content/repositories/orgapachezookeeper-1108/ > > > > > > > > The release candidate tag in git to be voted upon: release-3.9.4-0 > > > > https://github.com/apache/zookeeper/tree/release-3.9.4-0 > > > > > > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release: > > > > https://www.apache.org/dist/zookeeper/KEYS > > > > > > > > Should we release this candidate? > > > > > > > > My Signature: > > > > gpg: Signature made 二 5/ 6 18:11:50 2025 CST > > > > gpg: using RSA key > > > 8B374472FAD328E17F479863B379691FC6E298DD > > > > gpg: Good signature from "Zili Chen (CODE SIGNING KEY) < > ti...@apache.org > > > >" > > > > [unknown] > > > > Primary key fingerprint: 8B37 4472 FAD3 28E1 7F47 9863 B379 691F > C6E2 > > > 98DD > > > > > > > > Best, > > > > tison. > > > >
