Thanks Kezhu. I’ll create a work branch for 3.9.4 off the latest commit on branch-3.9 (I need to commit the logback and slf4j upgrade), because I want to include all completed tickets in this release. I’ll also modify jira tickets accordingly.
Andor > On Aug 7, 2025, at 10:05, Kezhu Wang <kez...@gmail.com> wrote: > > Hi Andor, > > Thank you for taking care of the next candidates! > > I created 3.9.5[1] during this vote period for backporting to > branch-3.9 and to avoid touching branch-3.9.4. There are currently > several issues that have been backported to branch-3.9 and marked as > resolved with fix version 3.9.5. Please take care of them in cutting > off the next candidates if you want to include them. > > Besides above, the ZOO_VERSION in zookeeper_version.h on branch-3.9.4 > is 3.9.3 still, see ZOOKEEPER-4928[2]. I did not create a backporting > pr for branch-3.9.4 due to possible conflict during the release period > as the version of that branch-3.9.4 has been advanced to > 3.9.5-SNAPSHOT. > > [1]: > https://issues.apache.org/jira/issues/?jql=project+%3D+ZOOKEEPER+AND+fixVersion+%3D+3.9.5 > [2]: https://issues.apache.org/jira/browse/ZOOKEEPER-4928 > > Best, > Kezhu Wang > > On Wed, Aug 6, 2025 at 6:34 PM tison <wander4...@gmail.com> wrote: >> >> Posted. >> >> Ah .. I should send the cancel email at the very first time :/ >> >> Best, >> tison. >> >> Andor Molnar <an...@apache.org> 于2025年8月6日周三 17:18写道： >>> >>> Hi tison, >>> >>> Yes, I can take this over. Please go ahead and Cancel this voting thread >>> and I'll create a new one in a few days. >>> >>> Regards, >>> Andor >>> >>> >>> >>> On 8/5/25 21:19, tison wrote: >>>>> Many folks are waiting for this release, so please let me know if don’t >>>>> have enough bandwidth to work on it. >>>> >>>> Hi Andor, >>>> >>>> I may not have time this month. So feel free to take it over. >>>> >>>> If it's possible, you can share with me what actions you take so that >>>> I can follow the cancel-revote process the next time more smoothly. >>>> >>>> Best, >>>> tison. >>>> >>>> Andor Molnar <an...@apache.org> 于2025年8月6日周三 05:01写道： >>>>> >>>>> Hi tison, >>>>> >>>>> I’ve also noticed that, but didn’t do anything about it last time I was >>>>> working on a release. It would be great if you could fix it, I’d really >>>>> appreciate it. >>>>> >>>>> A few patches have been committed to branch-3.9 since you created this >>>>> RC. Are you going to cancel it and create a new one? >>>>> >>>>> There’s also a logback upgrade waiting in the queue, but I’m not sure if >>>>> we need it. Many folks are waiting for this release, so please let me >>>>> know if don’t have enough bandwidth to work on it. >>>>> >>>>> Regards, >>>>> Andor >>>>> >>>>> >>>>> >>>>> >>>>>> On May 11, 2025, at 17:19, tison <wander4...@gmail.com> wrote: >>>>>> >>>>>> One thing I noticed is that our build logic may not sign and generate >>>>>> checksum for the binary tarball properly. I can manually sign and >>>>>> generate >>>>>> checksum for it, as I did for rc0, but it would be better if we fix it >>>>>> later. >>>>>> >>>>>> Best, >>>>>> tison. >>>>>> >>>>>> >>>>>> tison <wander4...@gmail.com> 于2025年5月11日周日 13:32写道： >>>>>> >>>>>>> Thank you. I'll look into these also and recut a candidate once all >>>>>>> pending items are done. >>>>>>> >>>>>>> Best, >>>>>>> tison. >>>>>>> >>>>>>> >>>>>>> Kezhu Wang <kez...@gmail.com> 于2025年5月11日周日 11:12写道： >>>>>>> >>>>>>>> -1 non binding >>>>>>>> >>>>>>>> The ZOO_VERSION in zookeeper_version.h is 3.9.3 still[1]. The built c >>>>>>>> cli outputs "Version: ZooKeeper cli (c client) version 3.9.3". >>>>>>>> >>>>>>>> See also ZOOKEEPER-4928[2]. >>>>>>>> >>>>>>>> [1]: >>>>>>>> https://github.com/apache/zookeeper/blob/release-3.9.4-0/zookeeper-client/zookeeper-client-c/include/zookeeper_version.h >>>>>>>> [2]: https://issues.apache.org/jira/browse/ZOOKEEPER-4928 >>>>>>>> >>>>>>>> Best, >>>>>>>> Kezhu Wang >>>>>>>> >>>>>>>> On Wed, May 7, 2025 at 11:57 AM tison <wander4...@gmail.com> wrote: >>>>>>>>> >>>>>>>>> Sounds reasonable. I'd leave this thread open for a while for further >>>>>>>>> feedback. >>>>>>>>> >>>>>>>>> Will take a look at the related patch. >>>>>>>>> >>>>>>>>> Best, >>>>>>>>> tison. >>>>>>>>> >>>>>>>>> >>>>>>>>> Kezhu Wang <kez...@gmail.com> 于2025年5月7日周三 00:33写道： >>>>>>>>> >>>>>>>>>> Hi tison, >>>>>>>>>> >>>>>>>>>> Thank you for driving this! >>>>>>>>>> >>>>>>>>>> I would expect that there is an email to discuss what else is left >>>>>>>>>> for >>>>>>>>>> the next release. >>>>>>>>>> >>>>>>>>>> I saw two candidates for the next release. >>>>>>>>>> >>>>>>>>>> 1. ZOOKEEPER-4921[1][2] partially rollback ZOOKEEPER-4508[3] to keep >>>>>>>>>> consistent with versions prior to 3.9.3 (excluded). I authored a dev >>>>>>>>>> mail[4] for this. Given that it is a rollback, I would like to see it >>>>>>>>>> in the next release so no more releases have the rollbacked behavior. >>>>>>>>>> 2. ZOOKEEPER-4925[5][6] fixed a data loss introduced in 3.9.3. From >>>>>>>>>> my >>>>>>>>>> point of view, this data loss is easy to trigger, so I would like to >>>>>>>>>> see it shipped in the next release. >>>>>>>>>> >>>>>>>>>> [1]: https://issues.apache.org/jira/browse/ZOOKEEPER-4921 >>>>>>>>>> [2]: https://github.com/apache/zookeeper/pull/2252 >>>>>>>>>> [3]: https://issues.apache.org/jira/browse/ZOOKEEPER-4508 >>>>>>>>>> [4]: https://lists.apache.org/thread/nfb9z7rhgglbjzfxvg4z2m3pks53b3c1 >>>>>>>>>> [5]: https://issues.apache.org/jira/browse/ZOOKEEPER-4925 >>>>>>>>>> [6]: https://github.com/apache/zookeeper/pull/2254 >>>>>>>>>> >>>>>>>>>> Best, >>>>>>>>>> Kezhu Wang >>>>>>>>>> >>>>>>>>>> On Tue, May 6, 2025 at 6:18 PM tison <wander4...@gmail.com> wrote: >>>>>>>>>>> >>>>>>>>>>> This is a release candidate for 3.9.4. >>>>>>>>>>> >>>>>>>>>>> This is a minor release. The full release notes is available at: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12355230&styleName=Html&projectId=12310801 >>>>>>>>>>> >>>>>>>>>>> *** Please download, test and vote by May 14th 2025, 23:59 UTC+0. >>>>>>>> *** >>>>>>>>>>> >>>>>>>>>>> Source files: >>>>>>>>>>> >>>>>>>>>> >>>>>>>> https://dist.apache.org/repos/dist/dev/zookeeper/zookeeper-3.9.4-candidate-0 >>>>>>>>>>> / >>>>>>>>>>> >>>>>>>>>>> Maven staging repo: >>>>>>>>>>> >>>>>>>>>> >>>>>>>> https://repository.apache.org/content/repositories/orgapachezookeeper-1108/ >>>>>>>>>>> >>>>>>>>>>> The release candidate tag in git to be voted upon: release-3.9.4-0 >>>>>>>>>>> https://github.com/apache/zookeeper/tree/release-3.9.4-0 >>>>>>>>>>> >>>>>>>>>>> ZooKeeper's KEYS file containing PGP keys we use to sign the >>>>>>>> release: >>>>>>>>>>> https://www.apache.org/dist/zookeeper/KEYS >>>>>>>>>>> >>>>>>>>>>> Should we release this candidate? >>>>>>>>>>> >>>>>>>>>>> My Signature: >>>>>>>>>>> gpg: Signature made 二 5/ 6 18:11:50 2025 CST >>>>>>>>>>> gpg: using RSA key >>>>>>>>>> 8B374472FAD328E17F479863B379691FC6E298DD >>>>>>>>>>> gpg: Good signature from "Zili Chen (CODE SIGNING KEY) < >>>>>>>> ti...@apache.org >>>>>>>>>>> " >>>>>>>>>>> [unknown] >>>>>>>>>>> Primary key fingerprint: 8B37 4472 FAD3 28E1 7F47 9863 B379 691F >>>>>>>> C6E2 >>>>>>>>>> 98DD >>>>>>>>>>> >>>>>>>>>>> Best, >>>>>>>>>>> tison. >>>>>>>>>> >>>>>>>> >>>>>>> >>>>> >>>
