On 4/29/20 6:36 PM, Leif Lindholm wrote:
We keep seeing new users (and copies) of EmbeddedPkg:s MmcDxe, which
while it predates the MdeModulePkg SD/(E)MMCsupport is in effect
unmaintained and also duplicates core industry standard definitions.
Since we now have GetMaintainers.py to parse Maintainers.txt for us,
extend its functionality to warn about less supported code.
Then as an indication of its unsuitability for reference (or use), set
its Status flag in Maintainers.txt to Obsolete.
Once this is done, follow up and do the same with the hardware drivers
(not the software ones) still left in EmbeddedPkg/Drivers. They were
added back when not using the UEFI driver model was still cool, or
simply before edk2-platforms existed.
They should move to edk2-platforms, but most of them require some
level of rewriting before that.
1/3 adds a warning printout to GetMaintainer.py
2/3 obsoletes EmbeddedPkg/Universal/MmcDxe/
3/3 obsoletes remaining hw drivers in EmbeddedPkg/Drivers
Cc: Andrew Fish <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Bob Feng <[email protected]>
Cc: Laszlo Ersek <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Michael D Kinney <[email protected]>
Leif Lindholm (3):
BaseTools: add handling for 'S:' flag to GetMaintainer.py
Maintainers.txt: mark EmbeddedPkg MmcDxe as Obsolete
Maintainers.txt: mark EmbeddedPkg hw drivers as bsolete
Acked-by: Ard Biesheuvel <[email protected]>
I am mostly concerned about the use of MmcDxe in new platforms. The
other bits I'm not too worried about, and I think it would be fine to
move those into Platform/ARM/VExpressPkg in edk2-platforms, instead of
hoping that someone will turn up and turn them into driver model drivers.
One thing I'd like to do in the short term is renaming
gEfiMmcHostProtocolGuid, given that it violates the naming rules, and
move the PL180 driver to edk2-platforms. Any thoughts about DwEmmcDxe?
Only HiKey uses that at the moment, given that socfpga apparently
switched to the generic version.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58320): https://edk2.groups.io/g/devel/message/58320
Mute This Topic: https://groups.io/mt/73356717/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
