On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote:
> > > I am mostly concerned about the use of MmcDxe in new platforms. The other
> > > bits I'm not too worried about, and I think it would be fine to move those
> > > into Platform/ARM/VExpressPkg in edk2-platforms, instead of hoping that
> > > someone will turn up and turn them into driver model drivers.
> >
> > We could, although I would prefer not adding code to edk2-platforms
> > that would not be accepted was it submitted as a new contribution.
> > The SATA controller, I would ideally re-review and merge properly.
> >
> > If we do include the other drivers in platform-specific directories, I
> > want them to come with ... strongly worded readmes.
> >
>
> Right.
>
> Should we have some format for that? A way to log shortcomings along with
> the code?
Thinking a bit more on this, maybe what we should do is add a template
to each file's top comment block. Draft proposal:
*
* WARNING:
* This driver fails to follow the UEFI driver model without a good
* reason, and only remains in the tree because it is still used by
* a small number of platforms. It will removed when no longer used.
* New platforms should not use it, and no one should use this as
* reference code for developing new drivers.
*
/
Leif
> > > One thing I'd like to do in the short term is renaming
> > > gEfiMmcHostProtocolGuid, given that it violates the naming rules, and move
> > > the PL180 driver to edk2-platforms.
> >
> > I did think about moving PL180 as well. I'm not opposed to moving
> > it. I don't think it's widely used.
> >
> > > Any thoughts about DwEmmcDxe? Only HiKey uses that at the moment,
> > > given that socfpga apparently switched to the generic version.
> >
> > Well, if nothing else it might be a useful scream test. Same comment
> > on strongly worded readme.
> >
>
> OK
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#58340): https://edk2.groups.io/g/devel/message/58340
Mute This Topic: https://groups.io/mt/73356717/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
