On 04/29/20 18:36, Leif Lindholm wrote: > A bunch of legacy drivers (most not compliant with UEFI driver model) > added for various ARM development platforms are still in EmbeddedPkg, > which was arguably the only possible location for them before > edk2-platforms was added. > > DwEmmcDxe, Isp1761UsbDxe, Lan9118Dxe, and Lan91xDxe all use a > Pcd*BaseAddress mechanism making them *fundamentally* incompatible > with the UEFI driver model, and preventing use of more than one device > instance per system. > > SataSiI3132Dxe *looks* like a proper UEFI driver, but would need > re-review with that in mind for moving to edk2-platforms. > > Mark these as Status: Obsolete in Maintainers.txt to at the very least > indicate that they are not suitable references. > > Cc: Andrew Fish <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Cc: Michael D Kinney <[email protected]> > Signed-off-by: Leif Lindholm <[email protected]> > --- > Maintainers.txt | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 4d62e0b334f3..3415a0410b7b 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -172,6 +172,11 @@ M: Alexei Fedorov <[email protected]> > > EmbeddedPkg > F: EmbeddedPkg/ > +X: EmbeddedPkg/Drivers/DwEmmcDxe/ > +X: EmbeddedPkg/Drivers/Isp1761UsbDxe/ > +X: EmbeddedPkg/Drivers/Lan9118Dxe/ > +X: EmbeddedPkg/Drivers/Lan91xDxe/ > +X: EmbeddedPkg/Drivers/SataSiI3132Dxe/ > X: EmbeddedPkg/Include/Protocol/MmcHost.h > X: EmbeddedPkg/Universal/MmcDxe/ > W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg > @@ -179,6 +184,11 @@ M: Leif Lindholm <[email protected]> > M: Ard Biesheuvel <[email protected]> > > EmbeddedPkg obsolete code > +F: EmbeddedPkg/Drivers/DwEmmcDxe/ > +F: EmbeddedPkg/Drivers/Isp1761UsbDxe/ > +F: EmbeddedPkg/Drivers/Lan9118Dxe/ > +F: EmbeddedPkg/Drivers/Lan91xDxe/ > +F: EmbeddedPkg/Drivers/SataSiI3132Dxe/ > F: EmbeddedPkg/Include/Protocol/MmcHost.h > F: EmbeddedPkg/Universal/MmcDxe/ > S: Obsolete >
same generic observations as under patch#2 Reviewed-by: Laszlo Ersek <[email protected]> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#58334): https://edk2.groups.io/g/devel/message/58334 Mute This Topic: https://groups.io/mt/73356720/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
