-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Georg von Zezschwitz wrote:
> >> Georg von Zezschwitz wrote: >> >> >>> Stipe Tolj wrote: >>> >>> >>>> ... >>>> Can't we think a bit to have "multi-directives" with the same name in >>>> a group? >>>> >>>> Obviously we would have to tweak the gwlib/cfg.[ch] here ;) >>>> >>> >>> I think this is an architecture issue, and I leave it to you in deep >>> respect :-) >>> >>> If we have "multi-directives", I'd be lucky to use them... >>> >> >> >> come on, you're just in the mood for submitting patches, go on :)) >> > > > OK, I looked at it. > > What I would do is > - adding a MULTIPLE to cfg.def and cfg.c, meaning that multiple values > might be > specified. yep. > - adding a WARNING (or should I panic?) if multiple definitions of the > same field > are occuring but the field is declared as OCTSTR. > (currently, a redefinition silently overwrites the old value - this > makes > it probably difficult to find mistakes for the user), . yep, agree here. panic() is appropriate here, IMO2. > - store a List instead of an Octstr for all MULTIPLE fields. yep, do we want ordering obeyed? Not sure. Makes sense for "routing decissions" in terms of "priortiy". > - replace cfg_get_list by a variant returning a list if the field is of > type MULTIPLE List *cfg_get_list() is returning a list? ;) > This *IS* touching architecture - does everyone agree? now, it should *exptend* the gwlib/cfg.[ch] module of Kannel's gwlib library. It's not doing a whole re-write and API change? ;) Any comments from the others? Stipe - ------------------------------------------------------------------- Kölner Landstrasse 419 40589 Düsseldorf, NRW, Germany tolj.org system architecture Kannel Software Foundation (KSF) http://www.tolj.org/ http://www.kannel.org/ mailto:st_{at}_tolj.org mailto:stolj_{at}_kannel.org - ------------------------------------------------------------------- -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFGKeFf9ez0oeKvYs0RAnuHAJ4xVKinQYvTCYFjU/Ra6u/adKYTNgCg2+uL 1A/G7a0PyjozU2xBMlPATDU= =i+OZ -----END PGP SIGNATURE-----
