Hi Nikos,
if you write "fixed indentation" then I assume it's fixed. But as far as I see
it's not and your fix made it even worse...
Please fix it and provide doc and I will commit it.
Thanks in advance.
Here are comments:
+#define MAX_SMS_OCTETS 140
+#define CATENATE_UDH_LEN 5
dont' redefine it, just include sms.h
+static Octstr *SMS = NULL;
please use downcase..
+ if (SMS)
+ {
please use
if () {
...
} else {
...
}
+ goto single;
it's not needed, why not just if (sms && octstr_len(SMS) <= (MAX_SMS_OCTETS *
8)/7) ...
+ uchar *start = octstr_get_cstr(SMS), *p = start, *end, c;
kill extra chars between uchar & *start
+ if (len%part_len) num_msgs++;
if you think it's readable then it's not, please use:
+ if (len % part_len)
num_msgs++;
+ pdu = smpp_pdu_create(deliver_sm, counter_increase
+ (message_id_counter));
hmm such line truncate is not very helpful...
+ debug("smpp.test", 0, "Announcing smsbox %s to bearerbox", octstr_get_cstr
+ (smsbox_id));
ditto...
Am 01.07.2010 um 06:29 schrieb Nikos Balkanas:
> Hi,
>
> Fixed identation. Beafed up smsbox_thread and routed most variables to
> configuration. Uses main kannel configuration. Just add an smpp smsc
> definition to 127.0.0.1 for it. It will test main kannel configuration in
> addition to TLVs. As already mentioned I extended its functionality to handle
> external messaging and concatenation. It is a FAKE smpp server, that also,
> benchmarks bearerbox's SMPP implementation.
>
> Anyone interested, please grab. If it makes it to kannel, i will also provide
> documentation.
>
> BR,
> Nikos
> <drive_smpp.diff>
