Hi Dan, Can you elaborate your statement ? I really think the logic was wrong...
Regards, Steven De Roo -----Oorspronkelijk bericht----- Van: Dan Carpenter [mailto:dan.carpen...@oracle.com] Verzonden: dinsdag 11 juni 2013 18:54 Aan: Martyn Welch CC: Greg Kroah-Hartman; de...@driverdev.osuosl.org; Manohar Vanga; De Roo, Steven Onderwerp: Re: [PATCH 1/2] vme: tsi148: CR/CSR logic arround the wrong way On Tue, Jun 11, 2013 at 05:03:14PM +0100, Martyn Welch wrote: > The logic in the init routine for the TSI148 is inverted. It isn't > switching on the CR/CSR space when it should be and is reporting it's on when > its not. > > Correct the logic to do the right thing. > This is fine, but for future reverence the original curly braces were correct. If either side of the if else statement has curly braces then both sides get them. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
