On 25. 03. 20 19:19, Neal Gompa wrote:
On Wed, Mar 25, 2020 at 2:16 PM Miro Hrončok<mhron...@redhat.com>  wrote:
On 25. 03. 20 19:10, Stephen Gallagher wrote:
In general, very few packages should even need conditionalizing at
all; that's why I've been saying that this discussion is premature.
Most of the Python packages we maintain in RHEL would need conditionalizing to
disable (part of) tests or docs.

Disabling regeneration of documentation I get, but why would you
disable running the tests? That stuff is important to ensure the
packages aren't broken as you maintain them, patch them, etc.

Mostly because there are missing test dependencies. That's why we disable (some) tests. For example I have packages that cannot be tested in RHEL buildroot, but I test them locally by building them in EPEL mock --with tests. If even EPEL isn't enough, I install packages from PyPI via pip to my mock buidroot and than build with %check enabled but without the problematic test BuildRequires.

Take for example python-pip (snippet from rawhide, added notes):

%if %{with tests}
BuildRequires:  python%{python3_pkgversion}-mock  # PowerTools
BuildRequires:  python%{python3_pkgversion}-pytest  # AppStream
BuildRequires:  python%{python3_pkgversion}-pretend  # EPEL
BuildRequires:  python%{python3_pkgversion}-freezegun  # EPEL
BuildRequires:  python%{python3_pkgversion}-scripttest  # missing
BuildRequires:  python%{python3_pkgversion}-virtualenv  # AppStream
BuildRequires:  python%{python3_pkgversion}-werkzeug  # AppStream
BuildRequires:  python%{python3_pkgversion}-pyyaml  # BaseOS

Miro Hrončok
Phone: +420777974800
IRC: mhroncok
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 

Reply via email to