On 5/18/21 12:45 PM, Kevin Kofler via devel wrote:

Ben Cotton wrote:
This Change proposes to replace SDL 1.2 with sdl12-compat, which uses SDL
2.0.
FYI, it took me just a few minutes of casually browsing commits to spot a
memory corruption bug in this code:
https://github.com/libsdl-org/sdl12-compat/commit/4c5e3b22593c4b48ac8129ae2096af5c00569dd4#commitcomment-50963635

Opened an issue for it[1] and was correctly shortly after[2]

It uses the exact same code as SDL 1.2 which has a version for i386 systems with inline assembly so that might need some eyes looking at it.


[1] https://github.com/libsdl-org/sdl12-compat/issues/56

[2] https://github.com/libsdl-org/sdl12-compat/commit/dacb4cf935ba3a6faee53c67d8973e2b375a3fe9

_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to