Michal Schorm <msch...@redhat.com> writes: > On Thu, Jan 19, 2023 at 3:36 PM Robbie Harwood <rharw...@redhat.com> wrote: >>> Would you see a value in e.g. some kind of a robot reminding >>> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI >>> check) >> >> Please don't. > > Would you mind expanding your answer a bit, please? > I'd like to learn why people would (not) like such a check or reminder.
First, there's no benefit to removal. Nothing is harmed by having something that always evaluates like `#if 0` unless it seriously impacts readability. Spec file "hygiene" is not inherently good (or inherently bad) beyond that. A check or reminder is another nag notification. We don't need more of those, especially for low-priority items. And to head something off: it's not better when someone provenpackagers the change in. Then there's an unnecessary revbump, and the maintainers's checkouts desync from the main repo (merge conflicts/rebase). Be well, --Robbie
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
