On 10/5/23 12:41, Kalev Lember wrote:
On Thu, Oct 5, 2023 at 10:07 AM Miroslav Suchý <msu...@redhat.com
<mailto:msu...@redhat.com>> wrote:
Dne 04. 10. 23 v 11:43 Martin Stransky napsal(a):
> Hello guys,
>
> Is there's a way how to set requested amount of ram for koji
builders?
>
> I'd like to use it as Firefox builds fail recently due low
memory, like
> https://bugzilla.redhat.com/show_bug.cgi?id=2241690
<https://bugzilla.redhat.com/show_bug.cgi?id=2241690>
>
> Thanks,
> Martin
>
Related - rpm has tunables that allows you to tune the build
according the available resources. However memory is not there:
https://github.com/rpm-software-management/rpm/pull/2418
<https://github.com/rpm-software-management/rpm/pull/2418>
https://rpm-software-management.github.io/rpm/manual/buildprocess.html
<https://rpm-software-management.github.io/rpm/manual/buildprocess.html>
Oh, nice, I didn't know about that! From a quick look, there are
actually two memory tunables, %_smp_tasksize_proc and %_smp_tasksize_thread.
Looks like the new thing would replace the constrain_build macro that
firefox.spec is using:
Instead of current:
# Require 4 GB of RAM per CPU core
%constrain_build -m 4096
It would use:
# Require 4 GB of RAM per CPU core
%global _smp_tasksize_proc 4096
It doesn't look like a huge win from the packager's point of view, but I
am sure it's better to use the rpm upstream limits instead of external
macros such as
constrain_build.<https://pagure.io/fedora-infrastructure/new_issue>
Yep, memory is certainly considered, it was really the main driver of
that change.
Compared to %constrain_build the big win is that memory is always
considered, regardless of whether the packager asked for it or not. It
would be a useful experiment to drop that tunable from the spec because
it probably isn't necessary anymore (with rpm >= 4.18 that is).
The other win is that the native version also covers threads, which
helps on 32bit systems in particular.
- Panu -
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
