* Florian: > Shouldn't NDEBUG be already active? This is how %cmake is defined: > -DCMAKE_CXX_FLAGS_RELEASE:STRING="-DNDEBUG"
Those are per-configuration flags. CMake only appends CMAKE_<LANG>_FLAGS_<CONFIG> to the compile line when CMAKE_BUILD_TYPE names that configuration. %cmake doesn't set CMAKE_BUILD_TYPE and neither does rocm-smi.spec, so with a single-config generator CMAKE_CXX_FLAGS_RELEASE is defined but never used. Those %cmake lines read to me as a guard against CMake's own Release defaults (-O3 -DNDEBUG) rather than a way to enable NDEBUG. Measured on rawhide (7.14.0) with an unmodified spec: $ grep '/usr/bin/g++' build.log | grep -c DNDEBUG 0 $ grep -c '/usr/bin/g++' build.log 34 With the patch every compile line carries it — the only g++ line without is "Check for working CXX compiler". The shipped package agrees: btop aborts with Assertion "false" failed in get_multiplier_from_str, which can only happen if assert() survived compilation. Igor -- _______________________________________________ devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
