On 17.2.2016 19:20, Ralf Corsepius wrote: > On 02/17/2016 06:51 PM, Jan Kratochvil wrote: >> On Wed, 17 Feb 2016 18:25:29 +0100, Ralf Corsepius wrote: >>> Remove -Werror. >> [...] >>> -Werror is useful to devs when actively working on code, but using it in >>> released production code to be used in packages is plain st***. >> >> -Werror has found me many times bugs in Fedora add-on patches not being > You are developing with upstream and are using Fedora a test bed. > > This is unlike the situation many packages are in. > For these, all -Werror does is to raise in most case negligible warnings to > errors and to causes FTBFS for negligible reasons, such indentation, unused > vars or other stylishness. > > This shows especially in situations like now, when gcc received a major update > starts to raise _warnings_ for a new set of issues, and -Werror enabled are > going to FTBFS in masses. > > In other words: WARNINGS are warnings and not errors for a reason.
In this case the warning which was turned into error saved us asses because the code would behave differently under too aggressive optimizations. It is not black-white question. -- Petr Spacek @ Red Hat -- devel mailing list devel@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/devel@lists.fedoraproject.org
