>Yi Zou wrote:
>> struct fc_els_lesb_bb5 is the same size as struct fc_els_lesb but the
>members
>> have different meanings according to FC-BB-5 about Link Error Status Block
>> (LESB).
>>
>> Signed-off-by: Yi Zou <[email protected]>
>> ---
>>
>> include/scsi/fc/fc_els.h | 14 +++++++++++++-
>> 1 files changed, 13 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/scsi/fc/fc_els.h b/include/scsi/fc/fc_els.h
>> index f943281..f7e3a83 100644
>> --- a/include/scsi/fc/fc_els.h
>> +++ b/include/scsi/fc/fc_els.h
>> @@ -635,7 +635,7 @@ struct fc_els_rpl_resp {
>> };
>>
>> /*
>> - * Link Error Status Block.
>> + * Link Error Status Block: T11 FC-FS-3 Rev3.0, Clause 21.4.8
>> */
>> struct fc_els_lesb {
>> __be32 lesb_link_fail; /* link failure count */
>> @@ -647,6 +647,18 @@ struct fc_els_lesb {
>> };
>>
>> /*
>> + * Link Error Status Block: T11 FC-BB-5 Rev2.0, Clause 7.10
>> + */
>
>If these are FCoE specific, they could go in fc_fcoe.h, and
>be filled in by libfcoe, not libfc. I'm not sure how important that
>is, but I have a desire to keep FCoE-specific stuff out of libfc and
>maintain libfc as something that will be appropriate for
>any FC HBA to use.
This should be just FCoE specific, so I agree that it makes sense to
let it reside in fc_fcoe.h.
>
>> +struct fc_els_lesb_bb5 {
>> + __be32 lesb_link_fail; /* link failure count */
>> + __be32 lesb_vlink_fail; /* virtual link failure count */
>> + __be32 lesb_miss_fip; /* missing FIP keep-alive count */
>> + __be32 lesb_symb_err; /* symbol error during carrier
>count */
>> + __be32 lesb_err_block; /* errored block count */
>
>My spell-checker doesn't like "errored". Try "blocks with errors"?
Yeah, I added "errored" to my dictionary as it appears in the spec.
>
>Take some of this as suggestions ... I'm being picky today, I know.
>It looks like good code.
Not picky at all, really appreciate your inputs.
Thanks,
yi
>
>> + __be32 lesb_fcs_error; /* frame check sequence error count
>*/
>> +};
>> +
>> +/*
>> * ELS RPS - Read Port Status Block request.
>> */
>> struct fc_els_rps {
>>
>> _______________________________________________
>> devel mailing list
>> [email protected]
>> http://www.open-fcoe.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
[email protected]
http://www.open-fcoe.org/mailman/listinfo/devel
