>>>>>> + * @sp: The sequence in the RLS exchange >>>>>> + * @fp: The RLS request frame >>>>>> + * @lport: The local port recieving the RLS >>>>>> + * >>>>>> + * Locking Note: The lport lock is expected to be held before calling >>>>>> + * this function. >>>>>> + * >>>>>> + * FIXME: how to check/indicate if we want support RLS for LESB? >>>>> If the LLD supports it? >>>> I don't know how the LLD will indicate to FCoE stack this is supported, >>>> possibly by netdev flags as well? I wanted call it out as I did not >>>> find any way to query if this feature is supported. >>> I think RLS is always supported, right? Make the LLDs all support it, >>> or indicate support with lport->tt.ldd_stats != NULL. >> I guess so, the spec says to reject if RLS is not supported, which is why >> I was wondering under what condition to not support it. > >We can just always support it going forward. The only condition not >to support it would be the way it was before you wrote this code! :-) >We reject all the ops that we don't support. > > Cheers, > Joe Cool, I am changing lld_stats() to be just get_lesb() to let LLD to pass LESB since as it carries two meanings for FCoE and FC HBA. If there is no get_lesb() from LLD, I am using fc_host_statistics to fill the LESB, in this way, I can keep the FC-BB-5 definition of the FCoE specific LESB struct just in fc_fcoe.h as you mentioned earlier.
Anyway, I am sending out updated patches in a few minutes for review. Thanks, yi _______________________________________________ devel mailing list [email protected] http://www.open-fcoe.org/mailman/listinfo/devel
