On Tue, Jan 20, 2004 at 10:32:12PM +0100, Nicolas Joly wrote:
>On Tue, Jan 20, 2004 at 10:28:16AM -0800, Mark Vojkovich wrote:
>> On Tue, 20 Jan 2004, Nicolas Joly wrote:
>>
>> > > If your lines are correct, you should be able to run:
>> > > http://www.xfree86.org/~mvojkovi/linetest.c
>> > > without artifacts.
>> >
>> > The lines seems wrong as i do see artifacts when running the
>> > program with zero width lines (works fine for w>0).
>>
>> If you add to the Section "Device" of the XF86Config file:
>>
>> Option "XaaNoSolidTwoPointLine"
>>
>> that will force the XAA to only use the driver's Bresenham line
>> export. Does that change the behavior?
>
>Yes ! I do not see the problem with the linetest program anymore.
>Will check (in a day or two) with the testsuite, and report.
So it looks like the attached patch should be committed?
David
--
David Dawes
developer/release engineer The XFree86 Project
www.XFree86.org/~dawes
Index: savage_accel.c
===================================================================
RCS file: /home/x-cvs/xc/programs/Xserver/hw/xfree86/drivers/savage/savage_accel.c,v
retrieving revision 1.23
diff -u -r1.23 savage_accel.c
--- savage_accel.c 22 Dec 2003 17:48:10 -0000 1.23
+++ savage_accel.c 25 Jan 2004 01:16:01 -0000
@@ -66,6 +66,7 @@
int length,
int octant);
+#if 0
static void SavageSubsequentSolidTwoPointLine(
ScrnInfoPtr pScrn,
int x1,
@@ -73,6 +74,7 @@
int x2,
int y2,
int bias);
+#endif
#if 0
static void SavageSetupForScreenToScreenColorExpand(
@@ -486,7 +488,6 @@
xaaptr->SolidLineFlags = NO_PLANEMASK | ROP_NEEDS_SOURCE;
xaaptr->SetupForSolidLine = SavageSetupForSolidFill;
xaaptr->SubsequentSolidBresenhamLine = SavageSubsequentSolidBresenhamLine;
- xaaptr->SubsequentSolidTwoPointLine = SavageSubsequentSolidTwoPointLine;
#if 0
xaaptr->SubsequentSolidFillTrap = SavageSubsequentSolidFillTrap;
#endif
@@ -1092,6 +1093,7 @@
}
+#if 0
static void
SavageSubsequentSolidTwoPointLine(
ScrnInfoPtr pScrn,
@@ -1151,6 +1153,7 @@
BCI_SEND( BCI_LINE_STEPS( 2 * (min - max), 2 * min ) );
BCI_SEND( BCI_LINE_MISC( max, ym, xp, yp, 2 * min - max ) );
}
+#endif
