jeffpc commented on this pull request.
> + "channel program", "t");
+ if (err == LUA_ERRSYNTAX) {
+ fnvlist_add_string(outnvl, ZCP_RET_ERROR,
+ lua_tostring(state, -1));
+ lua_close(state);
+ return (SET_ERROR(EINVAL));
+ }
+ VERIFY0(err);
+ VERIFY3U(2, ==, lua_gettop(state));
+
+ /*
+ * Convert the input nvlist to a Lua object and put it on top of the
+ * stack.
+ */
+ if (nvarg == NULL) {
+ lua_pushnil(state);
This should probably be done in zcp_nvpair_value_to_lua
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/397#pullrequestreview-43932311
------------------------------------------
openzfs-developer
Archives:
https://openzfs.topicbox.com/groups/developer/discussions/Tffb276f83a8ecdd2-Me82986cbd64f338c82965ccb
Powered by Topicbox: https://topicbox.com